Skip to content

Set USE_PACKAGE_VERSION back to 'true'#11190

Merged
ebeahan merged 3 commits intoelastic:mainfrom
ebeahan:revert-use-package-version-false
Nov 14, 2025
Merged

Set USE_PACKAGE_VERSION back to 'true'#11190
ebeahan merged 3 commits intoelastic:mainfrom
ebeahan:revert-use-package-version-false

Conversation

@ebeahan
Copy link
Member

@ebeahan ebeahan commented Nov 14, 2025

What does this PR do?

Reverts the change to USE_PACKAGE_VERSION="false" needed for #11106.

Needs #11189 first.

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@ebeahan ebeahan requested a review from a team as a code owner November 14, 2025 13:53
@ebeahan ebeahan requested a review from a team as a code owner November 14, 2025 13:53
@ebeahan ebeahan marked this pull request as draft November 14, 2025 13:54
@mergify
Copy link
Contributor

mergify bot commented Nov 14, 2025

This pull request does not have a backport label. Could you fix it @ebeahan? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ebeahan ebeahan marked this pull request as ready for review November 14, 2025 15:24
@ebeahan ebeahan mentioned this pull request Nov 14, 2025
Merged
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 14, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @ebeahan

@ebeahan
Copy link
Member Author

ebeahan commented Nov 14, 2025

The remaining failures are related to known problem: #10917.

I'd like to get this reverted ASAP and the failures are not related to packaging. Force merging.

@ebeahan ebeahan merged commit f3e6551 into elastic:main Nov 14, 2025
18 of 21 checks passed
@ebeahan ebeahan deleted the revert-use-package-version-false branch November 14, 2025 19:37
hayotbisonai pushed a commit to hayotbisonai/elastic-agent that referenced this pull request Nov 23, 2025
@ebeahan @hayotbisonai
Set USE_PACKAGE_VERSION back to 'true' (elastic#11190)
e793a52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v1v v1v v1v approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@ebeahan ebeahan

Labels

backport-skip Cleanup skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ebeahan @elasticmachine @v1v